892 - Delete actions in viewer delete files permanently

[Dreamer]

To reproduce:
- in Windows - Recycle Bin Properties, use option "Custom size" for all disks, to move deleted files to recycle bin
- use default settings in FC
- empty recycle bin and open it in Explorer or FC, in the right panel
- create any file for testing in the left panel
- F3 to open it in viewer
- click the Delete toolbar button or use Del key
- click Yes button
= file is deleted permanently

It's the same with the option "Delete - no confirmation".

It works good in the main FC window.

892 (and 892-1 test) 64-bit donor portable, and 880 32-bit public, Windows 10 22H2 64-bit.

[Dreamer]

================================================================================
Important changes and bug fixes in the release 893
================================================================================
- Changed: Default delete operation in viewer changed from permanent delete to delete to recycle bin; both delete types are available for toolbar and shortcuts

I know it was changed in 893, default actions were changed, toolbar button and shortcut, but these actions are still broken:

"Delete" - is broken, delete file permanently
"Delete - no confirmation" - is broken too, delete file permanently

I think this bug is danger, since those actions are the same as in the main FC window, but they delete files permanently in viewer, so users could lost their files.

First problem is, that toolbar button is still "Delete - no confirmation" with my custom settings, so the files can be deleted permanently for users, who don't change this toolbar button.

Another problem is, that not each user read the forum and changelogs, so they could still assign those broken Delete actions for toolbar or/and shortcut.

[Dreamer]

Changes in 894:

The actions available currently for toolbar and shortcuts are:
- Delete to recycle bin (default action)
- Delete to recycle bin - no confirmation
- Delete permanently
- Delete permanently - no confirmation

This way is safe enough, it's clear that 2 actions delete items permanently.

Considered as fixed, thanks, Marek.

Closed.