598 - quick filter toggle not working as expected

Bugs and issues - current donor version.
Post Reply
Message
Author
inglorious
Posts: 277
Joined: 31.08.2011, 22:10

598 - quick filter toggle not working as expected

#1 Post by inglorious » 21.08.2012, 17:47

shortcut has been changed to CTRL+Y.
from my understanding CTRL+Y should toggle quick filter on/off, but it does not.
quick filter only gets the focus, that's it, now one has to press enter in order to apply a filter.
Win7x64

User avatar
Dreamer
Site Admin
Posts: 3475
Joined: 19.08.2007, 21:40
Location: Slovakia

Re: 598 - quick filter toggle not working as expected

#2 Post by Dreamer » 21.08.2012, 18:11

Confirmed, a bug IMHO.

Another minor issue, error sound when disabling quick filter using a shortcut.

Scott_Y
Posts: 504
Joined: 02.10.2009, 02:46
Location: Colorado, USA

Re: 598 - quick filter toggle not working as expected

#3 Post by Scott_Y » 21.08.2012, 18:44

inglorious wrote:... from my understanding CTRL+Y should toggle quick filter on/off, but it does not.
I agree -- this has been my intuitive expectation. "Toggle" meaning "apply <--> escape the filter."
... quick filter only gets the focus, that's it, now one has to press enter in order to apply a filter.
As I remember, this is not new, but has been the case in previous versions as well (though I may be wrong).

User avatar
Dreamer
Site Admin
Posts: 3475
Joined: 19.08.2007, 21:40
Location: Slovakia

Re: 598 - quick filter toggle not working as expected

#4 Post by Dreamer » 21.08.2012, 20:08

As I remember, this is not new, but has been the case in previous versions as well (though I may be wrong).
You are right, but I still think it's a bug.

Scott_Y
Posts: 504
Joined: 02.10.2009, 02:46
Location: Colorado, USA

Re: 598 - quick filter toggle not working as expected

#5 Post by Scott_Y » 22.08.2012, 16:51

Dreamer wrote:You are right, but I still think it's a bug.
Right. I was just trying to give some historical context, that it didn't pop up fresh in 598.

Marek
Author
Author
Posts: 2535
Joined: 10.04.2006, 07:48
Location: Germany
Contact:

Re: 598 - quick filter toggle not working as expected

#6 Post by Marek » 24.08.2012, 18:45

quick filter toggle not working as expected
It is working as I expect.
Additionally for the release 599: new quick filter option added "Hotkey activates filter when field is not empty".

User avatar
Dreamer
Site Admin
Posts: 3475
Joined: 19.08.2007, 21:40
Location: Slovakia

Re: 598 - quick filter toggle not working as expected

#7 Post by Dreamer » 12.09.2012, 22:53

Thank you Marek, with this option it works as most users except, I think, but...

1. There is a beep when deactivating filter with shortcut, when deactivating using a button, there is no beep, so I think it's a (minor) bug.

2. I think this option ("Hotkey activates filter when field is not empty") should be definitely enabled by default.

inglorious
Posts: 277
Joined: 31.08.2011, 22:10

Re: 598 - quick filter toggle not working as expected

#8 Post by inglorious » 17.09.2012, 19:30

sorry, but I disagree. I don't think this is consistent!

first let's have a look at the "flat view command" and how it's working:

CTRL+B -> flat view is turned on
CTRL+B -> flat view is turned off

ok, so I can turn flat view on/off via CTRL+B (works as expected!)

now lets have a look at Quick View and its implementation:

CTRL+Y (filter is focused)
enter (filter is ON)
CTRL+Y (filter is OFF)
CTRL+Y (filter is focused)
... and so on

I don't think this is a good work-flow, especially when

CTRL+Y (quick filter is focused)
enter (filter is ON)
CTRL+Y (filter is OFF)
Enter
-> no filter is applied instead .. is executed

in my opinion CTRL+Y should behave exactly as CTRL+B and threrefore should toggle QF on/off!!!

update: some other toogle on/off commands including
ALT+T (folder. tree)
ALT+F (fav. tree)
F9 (dual/single panel)
CTRL+SHIFT+SPACE
Win7x64

User avatar
Dreamer
Site Admin
Posts: 3475
Joined: 19.08.2007, 21:40
Location: Slovakia

Re: 598 - quick filter toggle not working as expected

#9 Post by Dreamer » 17.09.2012, 21:11

inglorious - are you sure you have enabled this option before testing?
new quick filter option added "Hotkey activates filter when field is not empty"
As I said, it should be enabled by default, IMO it is not needed at all.

Regarding this function, currently, if that option is enabled, it works like this:

- CTRL+Y (filter is focused / ON)
- type desired text * (filter is still ON, while typing)
- CTRL+Y (filter is OFF)
- CTRL+Y (filter is ON)
- CTRL+Y (filter is OFF)
...

* this is necessary, unlike other toggle options, so it works good IMHO.

inglorious
Posts: 277
Joined: 31.08.2011, 22:10

Re: 598 - quick filter toggle not working as expected

#10 Post by inglorious » 18.09.2012, 17:59

oh, thanks! seems to work with the mentioned option set.
yeah, I agree with you the option should be enabled by default.
Win7x64

Scott_Y
Posts: 504
Joined: 02.10.2009, 02:46
Location: Colorado, USA

Re: 598 - quick filter toggle not working as expected

#11 Post by Scott_Y » 21.09.2012, 15:44

inglorious wrote:yeah, I agree with you the option should be enabled by default.
I agree also, so that the action works as expected for toggles. I think that has been the direction of this entire discussion.

User avatar
Dreamer
Site Admin
Posts: 3475
Joined: 19.08.2007, 21:40
Location: Slovakia

Re: 598 - quick filter toggle not working as expected

#12 Post by Dreamer » 21.09.2012, 23:45

Right, a question, do you hear that sound too?
1. There is a beep when deactivating filter with shortcut, when deactivating using a button, there is no beep, so I think it's a (minor) bug.

Scott_Y
Posts: 504
Joined: 02.10.2009, 02:46
Location: Colorado, USA

Re: 598 - quick filter toggle not working as expected

#13 Post by Scott_Y » 22.09.2012, 03:17

Ah, yes -- there is a ding only when deactivating a quick filter with Ctrl+Y, but not when using the button next to the Quick Filter text box. (Heh -- I didn't catch that before because my Windows setting is "No Sounds" -- good thing you asked specifically!)

Post Reply

Who is online

Users browsing this forum: No registered users and 206 guests